Skip to content

Suppress more shellcheck errors.#194

Merged
meisterT merged 1 commit into
DOMjudge:mainfrom
meisterT:shch
Oct 5, 2025
Merged

Suppress more shellcheck errors.#194
meisterT merged 1 commit into
DOMjudge:mainfrom
meisterT:shch

Conversation

@meisterT

@meisterT meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member

No description provided.

@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

This seems to block #193

@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

Hmmm, I still see the same error? @nickygerritsen do you know what I am doing wrong?

@nickygerritsen

Copy link
Copy Markdown
Member

Nope, especially since it's mentioning line 22.... which is now a comment

@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

before this change:

docker run --rm -v "$(pwd):/mnt" koalaman/shellcheck:stable \
    -e SC1090 -e SC2086 -e SC2046 \
    /mnt/./provision-contest/disable-turboboost_ht

In /mnt/./provision-contest/disable-turboboost_ht line 22:
  cpu_list=($(eval echo {$start..$end}))
            ^-------------------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).
                        ^------------^ SC2175 (style): Quote this invalid brace expansion since it should be passed literally to eval.

For more information:
  https://www.shellcheck.net/wiki/SC2207 -- Prefer mapfile or read -a to spli...
  https://www.shellcheck.net/wiki/SC2175 -- Quote this invalid brace expansio...

after this change no errors anymore... so confusing

@meisterT
meisterT force-pushed the shch branch 2 times, most recently from 5618f60 to b2c2004 Compare October 5, 2025 18:29
@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

I tried several ways of excluding the whole file, but still no success.

meisterT added a commit to meisterT/domjudge-scripts that referenced this pull request Oct 5, 2025
@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

Well, now I deleted the shellcheck workflow and ... it still runs???

@meisterT
meisterT merged commit 2193369 into DOMjudge:main Oct 5, 2025
2 of 4 checks passed
@meisterT

meisterT commented Oct 5, 2025

Copy link
Copy Markdown
Member Author

Since this somehow seems to run on an old state of the repo, I decided to merge it and see whether it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants