add IG square state versions#34
Open
elmeraa-usgs wants to merge 1 commit into
Open
Conversation
cnell-usgs
requested changes
Oct 24, 2023
cnell-usgs
left a comment
Member
There was a problem hiding this comment.
There's a lot of repeated code in the functions here that makes this fairly inefficient and challenging to make edits to. Most of the code is the same but the dimensions or positioning changes.
Go back through your ig and cart_state functions and re-use the existing functions. You may need to add parameters to the inputs for output dimensions, or nudging placement. You really only need a couple plotting functions - one to make the cartogram and one for the national view. These can be re-used to make the other formats by providing filtered data as an input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR makes square (1080 x 1080 pt) cartogram content for states of interest:
Deleware
Maryland