Updates and formats Building ISIS#190
Merged
Merged
Conversation
acpaquette
reviewed
Mar 19, 2026
acpaquette
left a comment
Contributor
There was a problem hiding this comment.
Overall looks great! A couple smaller things to address then this should be good
Kelvinrr
reviewed
Jun 1, 2026
| You will need to modify your `~/.bashrc` as follows: | ||
| ***Executables Directory:*** | ||
| Executables are placed in `build/bin` (and linked in `$CONDA_PREFIX/bin`). | ||
| For Example, to use ddt (with `$ISISROOT` set to the build directory): |
Collaborator
There was a problem hiding this comment.
I dont think ddt is that common of a tool, I think we should be like "to use the ddt debugger with a local build" (otherwise someone might be confused), or remove the mention of ddt.
Kelvinrr
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Building ISIS doc seemed to be kind of outdated and contain some things that don't work anymore. I tried to streamline the first half at least, based on my recent builds.
For Example:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: