Add support for polls in posts#14
Open
thunze wants to merge 33 commits into
Open
Conversation
This fixes the missing `expires_in` key in the poll object of the `/statuses` POST response causing `expiresIn` in the Java representation of that response to be set to 0 instead of `null`. The value `null` correctly causes `copyFields()` to skip the `expiresIn` field when copying over values from the response to be saved in the database. The integer 0 on the other hand would be copied as-is and thus stored in the database, even though this is not the value the user originally set before posting the status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the user to add polls to statuses via the UI. 📊
Introducing polls required a bunch of changes and additions, so I’ll comment on a few to hopefully make them easier to understand. ☕
Note that I originally started implementing this feature by copying from how media support is implemented.
Footnotes
API docs: https://docs.joinmastodon.org/methods/statuses/#create ↩