feat: add faceted classification filter sidebar#135
Merged
Conversation
kunfang98927
approved these changes
Jun 10, 2026
kunfang98927
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me overall. The feature is well-scoped, the UI integration is clean, and the tree/filter separation is nicely structured.
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faceted Classification Filter
Adds a sidebar panel for filtering rows by classification hierarchy. This implements a faceted search / faceted navigation pattern for the classification column, allowing users to browse and filter by category/type/modifier using a tree UI, instead of scrolling through a flat list of full classification strings.
Tree structure (Neume shape-small.docx example)
Features
by_valuefilterFiles added
Testing
Tested with
Neume shape-small.docx(20 rows) andSQUAREnotation-NEUMElevel.csv(39 rows, mixed categories). No console errors.