Fix multi-monitor snapshot display selection#283
Open
sposer wants to merge 4 commits into
Open
Conversation
Why: unnamed interactive controls could leave tree_node undefined during semantic tree construction. Impact: preserves existing unnamed-control behavior while avoiding traversal failures.
Why: Win32 monitor indices do not reliably match DXGI output indices. Impact: display selection keeps the existing monitor-index API while falling back when dxcam cannot service a region.
Why: display indices could diverge from Windows active monitor identity and DXGI output order on multi-monitor setups. Impact: Snapshot and Screenshot now resolve display filters through active display metadata, expose available displays in output, and keep the capture flash on the selected region.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Member
|
can you show a demo of it |
Author
Screens
McpServers{
"mcpServers": {
"windows-mcp": {
"command": "uvx",
"args": [
"windows-mcp",
"serve"
]
},
"windows-mcp-new": {
"command": "uv",
"args": [
"--directory",
"E:\\Private\\Windows-MCP",
"run",
"windows-mcp",
"serve"
]
}
}
}Show
|
Member
|
Can you also show a screenshot of one screen with use_ui_tree and use_annotation as true to check if any grounding is broken after that? I will merge the PR |
Author
It appears that the UI Tree is displaying an ‘No elements’ error? and the Annotations are present on Screen 1, they seem to be displayed as desktop icons, whereas those in the bottom taskbar on Screen 2 are not being displayed at all. Screenshots
|
Member
|
Is it possible show me the inspect.exe window in multi screen setup |
Author
Is this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes three focused fixes around desktop snapshot correctness:
Skip unnamed semantic children in the UI tree
Match DXCAM outputs by desktop geometry
Align Snapshot/Screenshot display selection with active Windows displays
display=[...]through active Windows display metadata.SnapshotandScreenshotdisplay filtering consistent with the actual capture region.Validation
uv run pytest tests/test_snapshot_display_filter.py tests/test_flash_overlay.py tests/test_screenshot_capture.py87 passedgit diff --checkuv run python -m py_compile src/windows_mcp/uia/core.pyNotes
ruff checkcurrently reports pre-existing lint issues in legacy UIA files; this PR does not broaden into lint cleanup.