cuprated: move SyncerHandle to BlockchainInterface#626
Open
redsh4de wants to merge 4 commits into
Open
Conversation
redsh4de
force-pushed
the
misc/syncer-to-bcinterface
branch
2 times, most recently
from
8417c1f to
f1a057b
Compare
SyntheticBird45
approved these changes
Jun 2, 2026
redsh4de
force-pushed
the
misc/syncer-to-bcinterface
branch
from
f1a057b to
fa1c7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
moves SyncerHandle to be accessable from BlockchainInterfac
Why
Symmetry. Syncer is spawned by the blockchain module, so it makes sense for it's handle to join the rest of the blockchain handle crew. Same way how
syncer.rsis located inblockchain/Where
cupratedHow
clone SyncerHandle into BlockchainInterface at construction and remove the field from Node. Embedders now should call
node.blockchain.syncer()to get a clone of the handle. Longer but reads nicer too imo