Fix clipboard line limit check on external update and other refactoring#10406
Open
antessial wants to merge 3 commits into
Open
Fix clipboard line limit check on external update and other refactoring#10406antessial wants to merge 3 commits into
antessial wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #10394, also refactored text height calculation a bit, now it only has two main (server-side and client-side) versions and should work more consistently. Also some other lesser improvements, such as keeping the icons when copying the clipboard content (maybe there are such issues, didn't search for them)
ASSUMED_CHARACTER_WIDTH being equal to 8 is discussable, might lower it to 6, 8 is pessimistic and should be a maximum character width for a default font