[pull] main from kubernetes-sigs:main#440
Merged
Merged
Conversation
A Workload owned by a single Pod (the pod integration: bare pods and e.g. Deployment replicas) is deleted together with its pod, so no future pod can ever consume a recomputed topology assignment. Kueue recomputes such assignments in two places today, and both make the stored assignment diverge from the node the still-running pod occupies, corrupting per-node capacity accounting in both directions (the real node is treated as free and over-admitted; the newly assigned node is blocked for other admissions): 1. Failed-node replacement: after NodeFailureDelay the node is marked unhealthy and the scheduler computes a replacement assignment, while the pod keeps running on the original node through transient NotReady blips. 2. Post-eviction requeue: an evicted (e.g. preempted) Workload is requeued and re-admitted with a fresh assignment within milliseconds, while its pod drains the termination grace period on the original node. With the SkipReassignmentForPodOwnedWorkloads gate enabled, Kueue instead (1) keeps the existing assignment during node replacement (the node stays tracked in .status.unhealthyNodes and is cleared on the next scheduling pass), and (2) sets Requeued=False on eviction, parking the Workload so it finishes with its pod. Recovery happens through the pod lifecycle: the owning controller's replacement pod arrives as a new Workload admitted with a fresh assignment. Workloads with any other owner, including pod groups, keep the existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )