-
Notifications
You must be signed in to change notification settings - Fork 41
CASM-5771 Fix for RR Ceph issue #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sravani-sanigepalli
wants to merge
6
commits into
release/1.7
Choose a base branch
from
CASM-5771
base: release/1.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+563
−1
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
519d67b
CASM-5771 Fix for CEPH issue faced after storage node rollout when RR…
sravani-sanigepalli 5e5f8a0
CASM-5771 Fixing few issues
sravani-sanigepalli 3c58c49
CASM-5771 Fixing shfmt issues
sravani-sanigepalli 69ad2f7
CASM-5771 Fixing shfmt issues
sravani-sanigepalli 6d6a5fa
Merge branch 'release/1.7' into CASM-5771
jpdavis-prof f592a19
CASM-5771 Adding RR CEPH upgrade script
sravani-sanigepalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -186,6 +186,16 @@ The specific scripts executed as part of this hook are `/usr/share/doc/csm/upgra | |||||||||||||||||||||||||||||
| **`NOTE`** The `management-nodes-rollout` stage creates additional separate Argo workflows when rebuilding NCN storage nodes. The Argo workflow names will include the string `ncn-lifecycle-rebuild`. | ||||||||||||||||||||||||||||||
| If monitoring progress with the Argo UI, remember to include these workflows. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| **`NOTE`** If `Rack Resiliency` is enabled, add the `_admin` label to all Ceph nodes before proceeding. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| (`ncn-m001#`) Add the `_admin` label to all Ceph nodes. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| for host in $(ceph orch host ls --format json | jq -r '.[].hostname'); do | ||||||||||||||||||||||||||||||
| ceph orch host label add $host _admin | ||||||||||||||||||||||||||||||
| done | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. (`ncn-m001#`) Execute the `management-nodes-rollout` stage with a single NCN storage node. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
|
|
@@ -204,7 +214,62 @@ The specific scripts executed as part of this hook are `/usr/share/doc/csm/upgra | |||||||||||||||||||||||||||||
| cray cfs components describe "${XNAME}" | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| The desired value for `configuration_status` is `configured`. If it is `pending`, then wait for the status to change to `configured`. | ||||||||||||||||||||||||||||||
| The desired value for `configuration_status` is `configured`. If it is `pending`, then wait for the status to change to be `configured`. | ||||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| **`NOTE`** If `Rack Resiliency` is enabled, there is a known corner case where the node would not transition to `configured` state for a long time. If this occurs, perform the following steps: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. From the output of `cray cfs components describe "${XNAME}"` that was run above, fetch the `CFS_SESSION_NAME` for the `rack_resiliency_for_mgmt_nodes.yml` playbook: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```toml | ||||||||||||||||||||||||||||||
| [[state]] | ||||||||||||||||||||||||||||||
| cloneUrl = "https://api-gw-service-nmn.local/vcs/cray/csm-config-management.git" | ||||||||||||||||||||||||||||||
| commit = "a3e8d330adb99215e2d4cd084fc38ff590718705" | ||||||||||||||||||||||||||||||
| lastUpdated = "2026-03-03T11:41:04Z" | ||||||||||||||||||||||||||||||
| playbook = "rack_resiliency_for_mgmt_nodes.yml" | ||||||||||||||||||||||||||||||
| sessionName = "batcher-75d4e8ee-b688-4ae8-9ecd-065d8a3c9705" | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| The value of `sessionName` is the `CFS_SESSION_NAME`. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. (`ncn-m#`) Identify the associated CFS pod with the session: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| CFS_POD_NAME=$(kubectl get pods --no-headers -o custom-columns=":metadata.name" -n services -l cfsession=<CFS_SESSION_NAME>) | ||||||||||||||||||||||||||||||
| echo "${CFS_POD_NAME}" | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. (`ncn-m#`) Inspect the Ansible logs for the CFS pod: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| kubectl logs -n services "${CFS_POD_NAME}" ansible | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. (`ncn-m#`) If the session is stuck at the following task for long time: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```text | ||||||||||||||||||||||||||||||
| TASK [csm.rr.ceph_zoning : Apply CEPH zoning] ********************************** | ||||||||||||||||||||||||||||||
| changed: [x3000c0s29b0n0 -> x3000c0s29b0n0] | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| TASK [csm.rr.ceph_haproxy : Copy ceph_haproxy.sh script to the target machine] *** | ||||||||||||||||||||||||||||||
| changed: [x3000c0s29b0n0] | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Then delete the CFS pod: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| kubectl delete pod -n services "${CFS_POD_NAME}" | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| A replacement CFS pod will be created automatically, and the session should proceed to completion successfully. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| **`NOTE`** If `Rack Resiliency` is enabled, run the following script from `ncn-s001`, which has access to the Kubernetes cluster. | ||||||||||||||||||||||||||||||
| The script waits for completion of Ceph Orchestrator operations, and updates the latest monitor configuration in several ConfigMaps. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| (`ncn-s001#`) Execute `RR_ceph_upgrade.sh` script | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| /usr/share/doc/csm/upgrade/scripts/RR_ceph_upgrade.sh | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. (`ncn-m001#`) Upgrade the remaining NCN storage nodes once the first has upgraded successfully. This upgrades NCN storage nodes serially. | ||||||||||||||||||||||||||||||
| Get the number of storage nodes based on the cluster and verify that it is correct. The storage canary node should not be in the list since it has already been upgraded. | ||||||||||||||||||||||||||||||
|
|
@@ -227,6 +292,18 @@ The specific scripts executed as part of this hook are `/usr/share/doc/csm/upgra | |||||||||||||||||||||||||||||
| $ncn --format json | jq -r ' .id+" "+.desiredConfig+" status="+.configurationStatus'; done | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| **`NOTE`** If `Rack Resiliency` is enabled, remove the `_admin` label from all Ceph nodes except `ncn-s001`. The storage canary node (`ncn-s001`) retains the `_admin` label as it functions as the primary Ceph administration node. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| (`ncn-m001#`) Remove the `_admin` label from all Ceph nodes except `ncn-s001`. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| ```bash | ||||||||||||||||||||||||||||||
| for host in $(ceph orch host ls --format json | jq -r '.[].hostname'); do | ||||||||||||||||||||||||||||||
| if [ "$host" != "ncn-s001" ]; then | ||||||||||||||||||||||||||||||
| ceph orch host label rm $host _admin | ||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||
| done | ||||||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||||||
|
Comment on lines
+299
to
+305
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| 1. Perform the NCN master node upgrade of `ncn-m002` and `ncn-m003`. | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| > **`NOTE`** If Kubernetes encryption has been enabled via the [Kubernetes Encryption Documentation](../../kubernetes/encryption/README.md), | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.