Skip to content

fix(subdirectory): star-rating ratings widget assets under subpath (24.05 backport)#7663

Merged
ar2rsawseen merged 1 commit into
release.24.05from
fix/subpath-star-rating-assets-24.05
Jun 4, 2026
Merged

fix(subdirectory): star-rating ratings widget assets under subpath (24.05 backport)#7663
ar2rsawseen merged 1 commit into
release.24.05from
fix/subpath-star-rating-assets-24.05

Conversation

@ar2rsawseen

Copy link
Copy Markdown
Member

Summary

Follow-up to #7661 — the star-rating half of countly-platform#420 that was added after #7661 merged (pushed to the merged branch, so it never landed; fresh PR for just that delta).

  • star-rating/.../countly.views.js: prefix the ratings empty-state image with countlyGlobal.path (was root-absolute, 404s under subpath).
  • star-rating/.../ratings.scss: rating-preview emoji/thumb/star background-image URLs made relative (../images/…) instead of root-absolute, so they resolve under both root and subdirectory deploys.

node --check passes; SCSS converted +16/-16. Compiled ratings.css rebuilt by CI.

🤖 Generated with Claude Code

Backport of the star-rating half of countly-platform#420 to 24.05:
- countly.views.js: prefix the ratings empty-state image with
  countlyGlobal.path (was root-absolute "/star-rating/...", 404s under a
  subdirectory deploy).
- ratings.scss: make the rating-preview emoji/thumb/star background-image
  URLs relative (../images/...) instead of root-absolute, so they resolve
  under both root and subdirectory deploys.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 4, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ar2rsawseen ar2rsawseen merged commit ebf439b into release.24.05 Jun 4, 2026
5 of 7 checks passed
Copilot stopped reviewing on behalf of ar2rsawseen due to an error June 4, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants