fix(subdirectory): star-rating ratings widget assets under subpath#7662
Merged
Conversation
Two more subdirectory-deploy fixes added to countly-platform#420:
- countly.views.js: the ratings empty-state image used a root-absolute
path ("/star-rating/images/star-rating/ratings-empty.svg"), which 404s
under a subdirectory deploy. Prefix it with countlyGlobal.path (safe —
this is a JS string, not a Vue template expression).
- ratings.scss: the rating-preview emoji/thumb/star background-image URLs
used root-absolute paths (url("/star-rating/images/...")); make them
relative (url("../images/...")) so they resolve correctly from the
served /<subdir>/star-rating/stylesheets/ratings.css under both root
and subdirectory deploys.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cookiezaurs
approved these changes
Jun 4, 2026
Copilot stopped reviewing on behalf of
ar2rsawseen due to an error
June 4, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7660 — the two additional changes that were added to countly-platform#420 after #7660 had already merged. (They were pushed to the #7660 branch post-merge, so they never landed; this is a fresh PR for just that delta.)
star-rating/.../countly.views.js: the ratings empty-state image used a root-absolute path ("/star-rating/images/star-rating/ratings-empty.svg"), which 404s under a subdirectory deploy. Prefix withcountlyGlobal.path(safe — JS string, not a Vue template expression).star-rating/.../ratings.scss: the rating-preview emoji/thumb/starbackground-imageURLs were root-absolute (url("/star-rating/images/…")); make them relative (url("../images/…")) so they resolve from the served/<subdir>/star-rating/stylesheets/ratings.cssunder both root and subdirectory deploys.node --checkpasses oncountly.views.js; SCSS converted+16/-16. Compiledratings.css/ minified bundles are rebuilt by CI.🤖 Generated with Claude Code