Skip to content

Improve Account Class and Restore UT#2

Open
Costallat wants to merge 18 commits into
mainfrom
fb-improve-account-and-recover-utests
Open

Improve Account Class and Restore UT#2
Costallat wants to merge 18 commits into
mainfrom
fb-improve-account-and-recover-utests

Conversation

@Costallat

@Costallat Costallat commented Dec 15, 2021

Copy link
Copy Markdown
Owner

Signed-off-by: Renato Foot costallat@hotmail.com

Description

  • Improve Account class
  • Restore unit test

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

github-actions[bot]
github-actions Bot reviewed Dec 15, 2021
View reviewed changes
Comment thread src/creatures/players/account/account.cpp Outdated
Comment thread src/creatures/players/account/account.cpp Outdated
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/game/game.cpp
Comment thread src/io/iologindata.cpp Outdated
github-actions[bot]
github-actions Bot reviewed Dec 15, 2021
View reviewed changes
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
Comment thread src/game/game.cpp Outdated
@Costallat Costallat changed the title Pick store c++ changes Improve Account Class and Restore UT Dec 15, 2021
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from 36234c1 to be42348 Compare December 23, 2021 18:53
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch 2 times, most recently from 4473504 to 28affcd Compare December 23, 2021 20:21
github-actions[bot]
github-actions Bot reviewed Dec 23, 2021
View reviewed changes
Comment thread src/io/iologindata.cpp Outdated
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from 28affcd to 48e398f Compare December 30, 2021 18:34
@github-actions github-actions Bot added the data label Dec 30, 2021
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from c9c2f3a to c3251b6 Compare December 30, 2021 18:43
@github-actions github-actions Bot removed the data label Dec 30, 2021
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch 3 times, most recently from 2ef8c16 to db335eb Compare January 10, 2022 12:41
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch 2 times, most recently from 34c4fad to c50d02a Compare January 10, 2022 16:38
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from c50d02a to 488cd0f Compare January 10, 2022 16:40
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from 488cd0f to d0deb92 Compare January 10, 2022 17:48
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from d0deb92 to eea337e Compare January 10, 2022 17:56
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from eea337e to d733234 Compare January 11, 2022 12:05
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from d733234 to 52dd795 Compare January 11, 2022 12:49
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch 2 times, most recently from 43e3ae4 to 9d6901a Compare January 11, 2022 13:15
@Costallat Costallat force-pushed the main branch 2 times, most recently from e517f23 to 6a9428e Compare January 11, 2022 18:50
@Costallat
Add UT coverage report
a9af991 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Add UT coverage report
7cbfdac 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Pick store c++ changes
0cebbb0 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Remove Jenkinsfile
6f0ac5e 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Improved Account
fd84aaf 
- Refactor account class
- Create interface to save/load account information

Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Try to fix windows build
b17903f 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Try fix build windows
8d47974 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Improve account class
1c82901 
- Create account definitions
- Create account storage interface
- Create account storage DB class

Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Restore UT and add account tests
cec93b3 
- Restore UT
- Add accound UTs

Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Add account interface variable
fd91f4e 
- Create account interface variable
- Initialize accounts interface over the code

Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Add test coverage report
455adf3 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Remove appveyor
48a8feb 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Test coverage report
fbdbfd4 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat Costallat force-pushed the fb-improve-account-and-recover-utests branch from 9d6901a to fbdbfd4 Compare January 11, 2022 18:51
@Costallat
Add more account UT
efab637 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Copy server configuration
8f9d10c 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Fixes
24c1193 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Removes cpplint
c8c6534 
It's not aggregating anything relevant, there are others tools that are
better and more updated.

Signed-off-by: Renato Foot <costallat@hotmail.com>
@Costallat
Add ninja package missing from some systems
8d7ccf9 
Signed-off-by: Renato Foot <costallat@hotmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Jan 13, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 110 Code Smells

11.8% 11.8% Coverage
11.1% 11.1% Duplication

@github-actions

github-actions Bot commented Feb 13, 2022

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

docker source Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Costallat