Conversation
Phim226
commented
Apr 10, 2026
Phim226
commented
Collaborator
- Refactored vector quantities to be 3 dimensional, in preparation for future improvements to 3D visualisation.
- Wrote new functions to calculate the vector value of periapsis and apoapsis from the eccentricity vector.
- Previous functions calculating the radius of apoapsis/periapsis renamed to radius_of_apoapsis/periapsis to reflect the difference.
- Minor refactor of value formatting function.
- The unit for radians was erroneously written as "rads" in docstrings. Renamed to "rad".
Refactor vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.