fix: conf strict parsing#1053
Merged
Merged
Conversation
- Flatten configs/server/test/ and configs/client/test/ into their parent directories in the test_data submodule (commit 73919a6) - Remove 8 *_doc.toml fixture files no longer needed - Update all Rust references: test_server.rs, vector_runner.rs, ckms/config.rs - Update 12 vector manifest.toml files (remove /test/ path segment) - Update docs: TESTS.md, crate/test_kms_server/README.md, gen_vector_readme.py - Fix test assertion: unknown_key_in_http_config_is_rejected no longer checks the field name in the error message (toml v0.8 does not propagate it for nested deny_unknown_fields)
HatemMn
approved these changes
Jul 10, 2026
HatemMn
left a comment
HatemMn
left a comment
Contributor
There was a problem hiding this comment.
red the whole PR but seems to have gone way beyond the scope of the title ? Is it possible to clarity the goals in the description ?
To my understanding :
- the toml issues are cleard
- toolchain updated
- some middlewares were updated and code reduced
LGTM anyway !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1000