Repository navigation
Prefix release binary zips with the release version - #180
Conversation
Assets are now named corgea-<tag>-<target>.zip (e.g. corgea-v1.16.0-aarch64-apple-darwin.zip). The npm bundler takes the tag and still accepts the legacy unversioned names so older releases can be republished. Co-authored-by: ibrahim <ibrahim@corgea.com>
corgea-security
left a comment
There was a problem hiding this comment.
Automated review risk: 2/5.
The versioned asset naming is consistently propagated across build, upload, npm bundling, and documentation. No blocking defects are evident from the supplied diff.
No critical or high-priority changes were found.
corgea-security
left a comment
There was a problem hiding this comment.
Approved by Dennis: high policy risk and automated risk 2/5.
There was a problem hiding this comment.
No merge blocker. The versioned asset name stays aligned across the release upload and the npm bundler, and the legacy name is only a fallback.
Checked against 5d14be5: tag and workflow_dispatch builds take the tag as-is (v1.16.0 → corgea-v1.16.0-<target>.zip); branch builds prefix v onto the single corgea version from cargo metadata (one line, 1.16.0, so the name is not vv… or multiline). npm-publish.yml passes that same tag into bundle-binaries.js, which looks for corgea-<tag>-<triple>.zip before corgea-<triple>.zip. A new release has no legacy zips, so a missing versioned asset still fails the publish. Republishing an older tag still finds the old names.
Run 36688415230 (this branch) archived and uploaded corgea-v1.16.0-<target>.zip on Linux and Windows, including corgea-v1.16.0-x86_64-pc-windows-msvc.zip. No previous review threads.
Sent by Cursor Automation: pr-flow


Release assets are now named
corgea-<tag>-<target>.zipinstead ofcorgea-<target>.zip, e.g.corgea-v1.16.0-aarch64-apple-darwin.zip.Changes
release-binaries.yml: new "Resolve Asset Name" step. Uses the dispatchtaginput, else the pushed tag, else (branch builds)v+ theCargo.tomlversion. Archive, release upload, and artifact upload all use that name.scripts/npm/bundle-binaries.js: now takes the release tag (bundle-binaries <assets-dir> <tag>) and looks for the versioned name first. It falls back to the legacy unversioned name so older tags can still be republished via manual dispatch.npm-publish.yml: passes the tag to the bundler.build_release.sh: local zips use the same naming.RELEASING.md: documents the new names (also corrects "6 target zips" to 7).Testing
corgea-v1.16.0-…,corgea-v1.17.0-…, andcorgea-v1.16.0-…(fromCargo.toml).v1.16.0release assets and ran the bundler against them renamed to the new scheme, and against the original legacy names. Both bundled all 5 npm targets, and the bundled musl binary reportscorgea 1.16.0. A missing asset or missing tag argument exits 1 with a clear message.actionlintpasses on both workflows.Note
Anything outside this repo that downloads
corgea-<target>.zipby fixed name (install scripts, docs,releases/latest/download/...links) will need the version in the URL starting with the next release. Existing releases keep their current names.