fix(cms): seed entryStack from originating page path in dynamic hole endpoint (#548) - #552
Open
ShreyasUday wants to merge 2 commits into
Open
ShreyasUday wants to merge 2 commits into
ShreyasUday wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #548 (split out from #546).
When dynamic Layer C holes are hydrated via
/_instatic/hole/<nodeId>?v=<version>&u=<page-url>,renderHoleFragmentinserver/handlers/cms/hole.tspreviously hardcodedentryStack: [].As a result,
{currentEntry.*}bindings inside dynamic hole subtrees (such as loop cell filters mixing{currentEntry.slug}and{route.query.*}) resolved to empty strings"". For example, a filter like"{currentEntry.slug}-{route.query.region}"on/courses/time-management?region=czevaluated to"-cz", causing queries to return no records and render empty.This change:
resolveOriginatingEntryinserver/handlers/cms/hole.tsusingcontentRouteFromPath(pageUrl.pathname)andgetPublishedDataRowByRouteto look up the published entry row.templateContext.entryStackwith[entryRow]when an entry row matches, allowing{currentEntry.*}bindings to resolve seamlessly inside dynamic holes.entryStack = []if the page path is not a content entry route.Verification
bun run buildbun testbun run lintChecklist