https://github.com/ConsenSys/eth-lightwallet/issues/182: createVault …#193
Open
abhiramhatolkar wants to merge 1 commit into
Open
https://github.com/ConsenSys/eth-lightwallet/issues/182: createVault …#193abhiramhatolkar wants to merge 1 commit into
abhiramhatolkar wants to merge 1 commit into
Conversation
…f invalid mnemonic occurs
|
What's the status of this PR? It would be nice to see this merged in |
Masperoo
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present if init function throws error if invalid mnemonic occurs which is not caught by createVault function. This results in end users unable to handle that error. Wrapping the call to init function with try catch and passing err to callback if error comes will allow users to gracefully handle the situation.