fix: resend original WHOAREYOU for any new ordinary packet during han…#234
Closed
usmansaleem wants to merge 2 commits into
Closed
fix: resend original WHOAREYOU for any new ordinary packet during han…#234usmansaleem wants to merge 2 commits into
usmansaleem wants to merge 2 commits into
Conversation
…dshake When a responder has already issued a WHOAREYOU challenge and receives a second ordinary packet with a different nonce, it now resends the original WHOAREYOU rather than issuing a fresh challenge. This matches the discv5 spec intent: hold one challenge per session attempt so the initiator can complete the handshake it already started. On the initiator side, WHOAREYOU validation is relaxed from 'must match the last sent nonce' to 'must match any recently sent nonce' (bounded window of 8). The nonce-to-session lookup in NodeSessionManager is updated to keep all recent nonces (not just the last), cleared together when the session is deleted, reset on handshake timeout, and cleared on AUTHENTICATED transition.
Contributor
Author
|
Closing due to new PR. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
fix: resend original WHOAREYOU for any new ordinary packet during handshake
When a responder has already issued a WHOAREYOU challenge and receives a second ordinary packet with a different nonce, it now resends the original WHOAREYOU rather than issuing a fresh challenge. This matches the discv5 spec intent: hold one challenge per session attempt so the initiator can complete the handshake it already started.
On the initiator side, WHOAREYOU validation is relaxed from 'must match the last sent nonce' to 'must match any recently sent nonce' (bounded window of 8). The nonce-to-session lookup in NodeSessionManager is updated to keep all recent nonces (not just the last), cleared together when the session is deleted, reset on handshake timeout, and cleared on AUTHENTICATED transition.
Fixed Issue(s)