Skip to content

Keep required review audits in the foreground #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gontzess merged 3 commits into from
Sep 25, 2026
Merged

Keep required review audits in the foreground #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27b07e4
Keep required review agents in the foreground
gontzess Sep 24, 2026
8aaa195
Document foreground audit completion in CI
gontzess Sep 25, 2026
de1f608
Pin the official Claude Code action v1.0.234 release
gontzess Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/pr-review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,12 @@ runs:
} >> "${GITHUB_ENV}"
- name: Run Claude PR Review
id: claude_review
uses: anthropics/claude-code-action@9ca9355b36297178e28d37c799d1c9c8a28e6507 # main: Claude Code 2.1.280
uses: anthropics/claude-code-action@9171db3e57d6a3140a37ddc2ba92788584e0ead6 # v1.0.234: Claude Code 2.1.282
env:
# This is a one-shot SDK turn: required audit agents must return before
# the parent finishes, rather than wait for a later background wakeup.
# Keep subagents available, but run their work in the foreground.
CLAUDE_CODE_DISABLE_BACKGROUND_TASKS: "1"
with:
anthropic_api_key: ${{ inputs.anthropic_api_key }}
github_token: ${{ inputs.github_token }}
Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ Keep broadly shared connector criteria in the connector mixin. Use repo-local
The review assesses the whole change, including intent, correctness, security,
meaningful test coverage, and operational risk. Prior findings are rechecked against
current code; resolving a thread does not remove an unfixed blocker from the verdict.

Required audit subagents run in the foreground: this is a one-shot CI review,
so their results must return before the parent finishes. Background task
handoffs are disabled; the job cannot resume a later conversation turn.

The agent posts its verdict in a working summary comment and never writes
review-state metadata. After a successful run, CI publishes the report as a NEW
comment carrying a visible reviewed-commit link and CI-owned review-state
Expand Down