feat(pumpkin-solver): Also require minimum number of conlicts before switching to VSIDS - #575
Closed
ImkoMarijnissen wants to merge 1 commit into
Closed
ImkoMarijnissen wants to merge 1 commit into
ImkoMarijnissen wants to merge 1 commit into
Conversation
Contributor
Author
|
Significantly degraded performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we switch to VSIDS as soon as we find a solution to allow VSIDS some time to learn. However, this can be problematic if a solution is found without finding any conflicts (i.e., without VSIDS learning anything).
To prevent this from occurring, this PR adds the additional condition that a minimum number of conflicts (by default 100) needs to be met before switching to VSIDS permanently.
TODO