Repository navigation
feat(pbs): let a mux override proposer_deadline_buffer_ms - #510
Open
JasonVranek wants to merge 1 commit into
Open
JasonVranek wants to merge 1 commit into
JasonVranek wants to merge 1 commit into
Conversation
A mux already overrides timeout_get_header_ms and late_in_slot_time_ms for its keys. proposer_deadline_buffer_ms joins them, with the same limits as in [pbs]: above 0 and under one slot. A mux that fails those limits is named in the error, and the warning for a bid request with no time left names the buffer and the mux. The mux test helper builds its mux through validate_and_fill, so the new test runs the fill, its limit check and the bid route reading the mux's value. wait_for_ready gets back its doc comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #506.
A
[[mux]]can now setproposer_deadline_buffer_msfor the keys it lists, as it already cantimeout_get_header_msandlate_in_slot_time_ms. A key outside every mux keeps the[pbs]value. The mux's value has the same limits as[pbs]: above0and under one slot, checked when the config loads.Changes
MuxConfigtakes an optionalproposer_deadline_buffer_ms, filled from[pbs]when unset, like the two existing overrides.mux <id>: ...), and the warning for a bid request with no time left after the buffer names the buffer and the mux.get_header) andconfig.example.toml.validate_and_fill, so the override and its limits run as they do in production.wait_for_readygets back the doc comment that feat(pbs): dial builders outside the config for ePBS requests #506 left onMuxedRelays.