Routing - WIP#4
Open
agamdua wants to merge 2 commits into
Open
Conversation
agamdua
commented
Nov 7, 2016
agamdua
commented
Contributor
- pass routing events via the bus (or leverage the official router properly)
We need to improve this to work with the sidebar.
agamdua
commented
Nov 7, 2016
|
|
||
| </div> | ||
|
|
||
| this.sidebarevents = riot.observable(); |
Contributor
Author
There was a problem hiding this comment.
are we actually using this anywhere?
agamdua
commented
Nov 7, 2016
| self.currentView.unmount(true) | ||
| } | ||
|
|
||
| console.log(viewName) |
agamdua
commented
Nov 7, 2016
| --> | ||
| <table class="table {table-bordered: opts.bordered, table-striped: opts.striped}"> | ||
|
|
||
| The same needs to be done with the css properties of the table class |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.