Skip to content

fix(test): increase timeout for flaky workflow_templates transfer test#197

Closed
snomiao wants to merge 0 commit into
mainfrom
fix/flaky-workflow-templates-test
Closed

fix(test): increase timeout for flaky workflow_templates transfer test#197
snomiao wants to merge 0 commit into
mainfrom
fix/flaky-workflow-templates-test

Conversation

@snomiao

@snomiao snomiao commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Increases the timeout for the should transfer new workflow_templates issue test from the default 5000ms to 15000ms
  • This test has been failing on main for 5+ consecutive runs due to the sflow pipeline with mocked DB and MSW handlers not completing within the default timeout
  • See PR feat: add gh-pr-release-tagger task to label released PRs #171 for context on related CI failures

Test plan

  • Verified all 3 active tests pass locally (3 pass, 3 skip, 0 fail in 3.21s)
  • CI passes on this branch

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 10, 2026 15:03
@vercel

vercel Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comfy-pr Ready Ready Preview, Comment Apr 10, 2026 3:04pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI flakiness in the GitHub issue transfer task tests by increasing the per-test timeout for the “should transfer new workflow_templates issue” test to allow mocked DB/MSW flows to complete more reliably.

Changes:

  • Increase the timeout for should transfer new workflow_templates issue from the default 5000ms to 15000ms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@snomiao snomiao closed this Apr 10, 2026
@snomiao
snomiao force-pushed the fix/flaky-workflow-templates-test branch from e0bcc0b to bcf045a Compare April 10, 2026 16:52
@snomiao

snomiao commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

This PR's change (increasing the test timeout to 15,000ms) has already been merged into main via another commit. After rebasing, the diff is empty. Closing as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants