Skip to content

Clarify capitalization consistency feedback - no changes needed#108

Closed
Copilot wants to merge 9 commits into
mainfrom
copilot/sub-pr-105-another-one
Closed

Clarify capitalization consistency feedback - no changes needed#108
Copilot wants to merge 9 commits into
mainfrom
copilot/sub-pr-105-another-one

Conversation

Copilot AI commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Reviewed feedback claiming capitalization inconsistency between lines 14, 18, and config in app/tasks/gh-issue-transfer-comfyui-to-desktop/index.ts.

Investigation findings:

  • All lines consistently use comfyanonymous/ComfyUI (lowercase owner, proper-case repo)
  • Matches actual GitHub repository path format
  • Consistent with codebase-wide pattern

Current state:

/**
 * Workflow:
 * 1. Fetch new/unseen issues from comfyanonymous/ComfyUI with label "desktop"
 * ...
 *    3. Close original issue in comfyanonymous/ComfyUI
 */

const config = {
  srcRepoUrl: "https://github.com/comfyanonymous/ComfyUI",
  // ...
};

No inconsistency found. Requested clarification from reviewer.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

snomiao and others added 9 commits November 5, 2025 18:04
This adds a new task to transfer issues labeled "frontend" from Comfy-Org/desktop to Comfy-Org/ComfyUI_frontend.

- Created gh-desktop-issue-transfer task with full workflow
- Added comprehensive test coverage with MSW mocking
- Follows same pattern as gh-frontend-issue-transfer
- Transfers issues with comments, labels, and assignees
- Tracks transferred issues to avoid duplicates

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Add runGithubDesktopIssueTransferTask to imports
- Register task in TASKS array
- Ensures desktop issues with 'frontend' label are transferred to ComfyUI_frontend repo

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Transfers issues labeled "desktop" from comfyanonymous/ComfyUI to Comfy-Org/desktop.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Transfers issues labeled "desktop" from Comfy-Org/ComfyUI_frontend to Comfy-Org/desktop.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Adds ComfyUI to Desktop and Frontend to Desktop issue transfer tasks to the automated task runner.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
…end/desktop repositories

- Added `gh-issue-transfer-comfyui-to-frontend` task to transfer issues from ComfyUI to ComfyUI_frontend.
- Added `gh-issue-transfer-desktop-to-frontend` task to transfer issues from Comfy-Org/desktop to ComfyUI_frontend.
- Added `gh-issue-transfer-frontend-to-desktop` task to transfer issues from ComfyUI_frontend to Comfy-Org/desktop.
- Created corresponding test files for the new transfer tasks to ensure functionality and error handling.
- Updated `run-gh-tasks.ts` to include the new transfer tasks in the task execution flow.
…s for better understanding and maintainability
…e transfer to allow processing of all issues
@vercel

vercel Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
comfy-pr Ready Ready Preview Comment Nov 6, 2025 3:40am

Base automatically changed from sno-desktop-issue-transfer to main November 6, 2025 03:41

Copilot AI commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/comfyanonymous/ComfyUI
    • Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update implementation based on feedback for desktop issue transfer Clarify capitalization consistency feedback - no changes needed Nov 6, 2025
Copilot AI requested a review from snomiao November 6, 2025 03:45
@snomiao snomiao closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants