Repository navigation
fix(reports): reissue a cached report when more of its calls are analysed - #9
Merged
Merged
Conversation
…ysed Analysis finishes a few minutes after a call ends. A report opened in that window was cached, and because the call's end time was earlier than the snapshot the cache kept serving it without the new analysis. Past periods were never reissued at all, so a Sunday-night call analysed on Monday stayed out of last week's report. Reuse the snapshot only when its analyzedCallCount still matches the analysed calls in the period. No migration; snapshots without the field are rebuilt once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A report opened while a call was still being analysed was cached without that call, and the cache kept serving it after the analysis finished because the call's end time was earlier than the snapshot. Past periods were never reissued, so a Sunday-night call analysed on Monday stayed out of last week's report.
The snapshot is now reused only while its
analyzedCallCountmatches the analysed calls in the period. No migration; snapshots without the field are rebuilt once.Tests: two regression tests (fail before the fix), full suite 341 passed, ruff clean.