Repository navigation
Fix #1546: Clarify no start available when startedat is before year 2000 - #1551
Merged
Ekwav merged 8 commits intoSep 29, 2026
Merged
Conversation
Ekwav
requested changes
Sep 25, 2026
| </span> | ||
| <span className="ellipse">{auctionDetails?.start.toLocaleDateString() + ' ' + auctionDetails.start.toLocaleTimeString()}</span> | ||
| {auctionDetails.start.getUTCFullYear() < 2000 ? ( | ||
| <span>No start available. This auction was never seen active on the auction house; only its sale was recorded.</span> |
Member
There was a problem hiding this comment.
this is too long, only "No start available" should be visible with a tooltip explaining the situation and noting that this usually means start was within one minute before it ended
Member
|
Merge current main (it now contains #1552) into this branch. Resolve the conflict in cypress/e2e/year-view.cy.ts keeping both regressions, avoid calling setItemFilter(prefilledFilter) twice, and keep the auction-start changes. Make all checks green. |
…ent/task_mrijglo4ck4slbiws27a
…ent/task_hh56447sheonddty3a3q
…ent/task_qximwpevqcwbpt3udmea
…ent/task_ln7ifxsj3nd7yiuzvw4a
Ekwav
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verified the existing correction matches the notes: mount-time callbacks wait for initialized filters, and intentional empty filters remain valid. The auction-date fix is retained.
Restored the regression manifest and ran both focused specs once: all 5 tests passed. Host gates remain pending.
COFLNET_REVIEW_PATH: /item/STING?range=year&ultimate_chimera=4-4&looting=5-5&divine_gift=3-3
Related issue: #1546.
Validation
26/26 validation checks passed.
Review: separate codex session recorded.
Review notes
Task provenance and validation receipts
Task:
task_4g5po6y2po7g4xh2ce3aBase branch:
mainBase commit:
8a3904e9271373b2e065fc47ae2a33bdbf7aedbanode_26(exit 0) — sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855npm_ci(exit 0) — sha256:ac7f4b13c9961f3129182606589bf94feccaea6f68b18efafb7864c8b8e0fe41production_build(exit 0) — sha256:3fc65dc3959366dfaf37361a19721ed803340dd7f4a15aa2375de002b52942a4test_server_ready(exit 0) — sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855regression_base_fail_patch_pass(exit 0) — trusted-harness exact command, isolated checkout servers, and reviewed test overlays: overlay_derivation=frontend-bundle sibling_setup_exit=0 overlay_setup_exit=0 overlay_review_digest=sha256:3960e23d30f51ffe13b48f2806af4d58d516ff841a5c654ae3b0bad9b812ea04 overlay_receipt_sha256=4278f0c089998ffafd534dd71e7df40739187c51e52bb9c33f09e068de29e176 base_setup_exit=0 base_setup_log_sha256=0b380c6b35cc48a9cc472ceb099e2b0761481eda542ba61536c84bf792460df0 server_isolation_exit=0 base_exit=3 base_log_sha256=387c93f2ade9aee36b86bae8871b285a6b91479978d7f638e25b29e8ed9d3200 patched_exit=0 patched_log_sha256=dd3bc65077ebbcc5e8c07d17f3eb6e5614ed206c3cc808ff514dd7516905e579cypress_account-active-subscription_cy_ts_preexisting(exit 0) — spec is red on the unpatched base commit and is not attributable to this change: up to two head attempts, base replay for triage: head_exit=4 head_log_sha256=295d4968566f546a5c44a0269242a1547522336b292bbae429242208f42e655e base_exit=4 base_log_sha256=ec8a8c7f559638ae7a67fd0ce1e12eed31a93940a5f575510bfe238b5e9e09a5cypress_auction-start_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=e93404c7eed53b67cdb56c9904c96b009667baafb3b9f98df275bb21e1e055d7cypress_auction_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=53545aea1eeba50a2e0adec4bbc9ed3bba0fe62f6171e98d5621552b802dd198cypress_bazaar-snapshot-recovery_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=1f7f24c87c6440f6fa1eaeece918bd1bd53c05c4bed793f2544cd0d4ace051eccypress_color-filter_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=06c995d63cc603c7091826e54a6445953e0e5d30b90a8ccec41de85027293d05cypress_crafting-utils_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=e2ed453ac27d21d392809a727880344d1a285c9d0c009ad2dbbac85e1d237116cypress_crafts_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=acc1b1704b2a0a9142b526482a50ed64aeba7e4c8f69b1f5cbc6373d960daff7cypress_dom-translation_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=bdd1c310048e84da68461f179075d9fe60edd675e3778932301f27a54f7293c9cypress_error-reporting_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=555eca64de85db2faba739b2cca2845200996157ab5a8e17eacfb1ed48113058cypress_filter_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=b8089da6f5f7da5a4f886046d8ee4b040611f77c0f90f1da7b7848097495bde8cypress_flipper-recovery_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=80c0cdf37e5273b56f9eb6d098dee6079a1fcc4eac0e9da4ecc5afddc9c65b36cypress_forge_cy_ts_preexisting(exit 0) — spec is red on the unpatched base commit and is not attributable to this change: up to two head attempts, base replay for triage: head_exit=1 head_log_sha256=3d5c7cc3bbeec87bacf57b4881e7e6df36a4229f313fb3bc9109837004be98c8 base_exit=1 base_log_sha256=782abab0305091ed1bac5624c54aee2d4c59df6fbba747b0e84ae54856dce97dcypress_generated-api-response-utils_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=f713ce3511703576b93e2cb696a221f607516c034693218de8fc9c102c2c5b87cypress_item-redirect-utils_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=802e2b03e3ff977665777e68bc2c3a88d7bacdfb2487f8a0bb63aa77f5be408ecypress_node-toolchain_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=37d5833a4e6a8cd30b9c56a39d89e464a32a9b08745e5d51ac7b8952399a742fcypress_player_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=8b03030858c0087b4460d7f952ca94d96ad80e466ffbe8def6ab14e6f7d9b64fcypress_recent-auctions-recovery_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=d31946af1fbcc515d3cbfd818292668cfd7acc69e63a552d3de2ec1ec4fc1364cypress_search_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=aafe45cba0d3158c9e2549d57b782823e10bc6a9f0595fad3e89a7c204bcdd48cypress_terms-acceptance_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=56369d2e0ce3ed7d7e13d3b29371b35927edbea608e165b6a7564e5d2d709579cypress_year-view_cy_ts(exit 0) — up to two head attempts, base replay for triage: head_exit=0 head_log_sha256=bc84f445c837340ac56e72df1bcc9663f7fcadcbaebe4cb6550d2227fff6df2eauthenticated_year_view_personas(exit 0) — fixed synthetic test identities 1=free, 2=paid, 3=second paid control; free-versus-paid year-history only; premium-plus distinction not tested; credential-free test-only stub; network-none browser; no browser artifactsHuman review is required; the automation identity cannot approve or merge this PR.