Repository navigation
Update Moq to 4.21.0 - #457
Merged
Ekwav merged 1 commit intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behaviour: Nothing changes for users. The test build now uses Moq 4.21.0 instead of 4.20.72. Moq is only referenced in non-Release configurations, so the production build is unaffected.
Change: In
SkyModCommands.csproj, theMoqPackageReferencegoes from4.20.72to4.21.0. The repository has no NuGet lockfile, so nothing else needed updating.Test: No new test, since this is a version bump. I rebuilt the Dockerfile's layout (sibling repos cloned next to
sky/) and randotnet testthere. All 331 of 331 existing tests passed, including every test that uses Moq, and restore resolvedMoq/4.21.0.Open: Upgrading Moq also raises its transitive dependency Castle.Core. The resolved version is now 5.2.1, up from the 5.1.1 minimum that 4.20.72 allowed, because 4.21.0 requires at least 5.2.1.
Dependency notes:
github.com/moq/moq.lib/*assemblies, with nobuild/oranalyzers/content.SkyFilterstill references Moq 4.20.72. That doesn't cause a conflict, because NuGet picks the higher version (4.21.0).Where to look: 0 changed lines of production code in 0 files, 0 changed lines of tests in 0 files, 1 other file.
Validation: 1/1 checks passed · reviewed in a separate codex session.
Dependencies: 3 changed, verified by the host.
nuget:Moq4.20.72→4.21.0nuget:Castle.Core5.2.1nuget:System.Threading.Tasks.Extensions4.6.3Checks and provenance
container_buildReview notes:
Task:
task_c6vuvmnd7eoh3v7c3ciqBase:
mainat7bce2f2f4e793a022346e802d7265a0ec24f39de