Preserve graph cache isolation, renderer lifecycle and scoped queries - #241
Coding-Dev-Tools wants to merge 19 commits into
Conversation
…shboard-cache-readiness-20260928
…shboard-cache-readiness-20260928
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a4583d838
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…shboard-cache-readiness-20260928
…ty in PNG export compositor
…928' into codex/dashboard-cache-readiness-20260928
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a36be53891
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This branch has not been deployed
1 participant
Graph callers receive isolated cached scenes for all layers and explicitly empty layers, and concurrent eviction or graph-job completion cannot turn a cache hit into an HTTP 500. Cache metadata changes share a lock; copying and database work remain outside it. Renderer pause state survives WebGL context loss and restoration.
PNG exports reproduce the authored CSS gradients, grid spacing, screen blending, reduced-motion opacity and foreground composition. Fractional display scaling preserves the canvas drawing scale and avoids stretching rounded gradient tiles. An independent browser screenshot supplies the pixel oracle.
Graph classification starts from scoped candidate entities and probes indexed source/destination edges, avoiding scans of unrelated repositories. Workspace-wide privacy for incident edges, time-travel behavior, pre-limit private filtering and traversal caps remain intact. A self-loop contributes one endpoint incidence. Secure erasure preserves a global entity referenced by a retained edge from any workspace. Workspace-owned entities still require exact-workspace incidence, so foreign edges cannot prevent their erasure. The indexed endpoint probes remain in that owned-entity branch.
The original local source snapshots are preserved in this branch and in verified recoverable patches. Stacked on #240; merge the #238 → #239 → #240 stack first.
Validation:
Cache identity preserves
layers=Noneseparately fromlayers=[]. Both query orders failed before repair; both now retain correct results on actual warm hits. Independent eight-dispatch probes passed with graph row rebuilding forbidden. The successful-refresh subject retirement fix from Include managed Jev for Pro and Team with current trials and workspace routing #240 is integrated, including persisted and in-process replay prevention; final combined graph/session/evidence/MCP qualification passed all 884 tests.Inherited from Include managed Jev for Pro and Team with current trials and workspace routing #240: All command decisions now keep automatic execution disabled, including overconfident remote advice. Required inputs validate before both local and remote processing; incomplete calls return null conclusions without backend lookup or allowance use. Completion requires state plus goal with action history optional; custom accepts state or question. The README, MCP reference, portable skill and generated contract describe this behavior. Four complete MCP modules passed 592 tests, with 20 final real-client mapping checks; selections overlap. Both review findings are fixed and resolved.
The README now documents the included Jev plan benefit, Classic/Smart decision entry points, explicit consent and managed/BYOK configuration. The earlier README-only correction passed all 42 documentation/package/skill checks; the final source is qualified by the fresh immutable evidence below.
Chromium lifecycle/export suite for the unchanged renderer: 20 passed, without retries or skips. Includes 11 PNG cases at DPR 1/2 plus Cyber at DPR 1.25. The original 10 PNG checks failed before repair; the fractional case independently reproduced resampling. CSS-to-export channel tolerance remains 3.
Final graph/cache selection: 211 passed, including deterministic concurrent clear/eviction and budget regressions. Final v115 evidence, documentation, render, package, skill and MCP selection: 884 passed. Final erasure/store/secret/FTS/tombstone selection: 333 passed, one existing skip. Six global/scoped-edge negative controls failed before repair; the final incidence matrix covers 24 cases. The full asset module passed 261 tests after correcting its CSS-ownership guard.
Earlier integrated graph/store/scene/privacy/history and relocation selection: 692 passed, one existing Windows POSIX-permission skip. Selections overlap and are not an additive unique-test count.
Deterministic SQLite VM counters reject unrelated-edge scan growth; query plans use endpoint indexes. This is not an end-to-end latency claim.
JavaScript syntax, Ruff, commercial manifest, dashboard assets and whitespace checks passed. Final pinned Pyright 1.1.414 project qualification passed.
Immutable v115 reruns unchanged fixture aggregates; all 583 source bindings match staged Git blobs. Earlier artifacts remain immutable. Draft v99/v100 source and publication snapshots remain recoverable.
Current head:
f10dbc40de2d8bb2b0b7ab9bddb4870f6115a64c. Cache, PNG and compatible global-incidence review findings are addressed and resolved. Strict MCP remote consent and a valid offline discovery example are integrated from #240. All 29 required GitHub checks passed on this revision. No production deployment, provider call or release is included.