London | 26-ITP-May | Raihan Sharif | Sprint 3 | Alarm Clock#1223
Open
RaihanSharif wants to merge 3 commits into
Open
London | 26-ITP-May | Raihan Sharif | Sprint 3 | Alarm Clock#1223RaihanSharif wants to merge 3 commits into
RaihanSharif wants to merge 3 commits into
Conversation
RaihanSharif
added
Needs Review
cjyuan
reviewed
May 10, 2026
Comment on lines
+19
to
+21
| const minutes = Math.floor(secondsRemaining / 60); | ||
| const seconds = secondsRemaining % 60; | ||
| displayTime(minutes, seconds, clockDisplay); |
Contributor
There was a problem hiding this comment.
These three lines of code are repeated on lines 33-35. Wouldn't it be better to compute the minutes and seconds in the displayTime() function?
cjyuan
added
Reviewed
RaihanSharif
added
Needs Review
cjyuan
reviewed
May 10, 2026
cjyuan
added
Reviewed
Removed unused variable 'setBtn' from setAlarm function.
RaihanSharif
added
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented the basic feature using setInterval. I tried to use setInterval to poll Date.now() every 500ms, as I thought that would be more robust, but the test suit meant I couldn't do that.