London | 26-ITP-May | Raihan Sharif | Sprint 2 | Exercises#1220
Open
RaihanSharif wants to merge 26 commits into
Open
London | 26-ITP-May | Raihan Sharif | Sprint 2 | Exercises#1220RaihanSharif wants to merge 26 commits into
RaihanSharif wants to merge 26 commits into
Conversation
Can account for special characters in key or value, unless fundametally unparseable, like & in key or value; or & in value.
…re are multiple values.
RaihanSharif
added
Needs Review
cjyuan
reviewed
May 10, 2026
|
|
||
| function contains(object, key) { | ||
| if (isObject(object)) { | ||
| return key in object; |
Contributor
There was a problem hiding this comment.
Consider the following two approaches for determining if an object contains a property:
let obj = {}, propertyName = "toString";
console.log( propertyName in obj ); // true
console.log( Object.hasOwn(obj, propertyName) ); // false
Which of these approaches suits your needs better?
For more info, you can look up JS "in" operator vs Object.hasOwn.
Author
There was a problem hiding this comment.
hasOwn excludes inherited properties. I hadn't considered that we'd want to exclude inherited properties.
I suppose in this case, we do want to exlcude inherited properties.
Contributor
There was a problem hiding this comment.
The spec didn't specify. So as long as you are aware of the difference, that's enough.
|
|
||
| if value at key is an array, and contains the incoming value, ignore. Else, push it to the array. | ||
| */ | ||
| if (Object.prototype.hasOwnProperty.call(queryParams, key)) { |
Contributor
There was a problem hiding this comment.
Could also use Object.hasOwn()
Comment on lines
+11
to
+13
| acc[curr] = (acc[curr] ?? 0) + 1; | ||
| return acc; | ||
| }, {}); |
Contributor
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion:
- Look up an approach to create an empty object with no inherited properties, or
- use
Object.hasOwn()
| if (Object.prototype.hasOwnProperty.call(invertedObj, String(value))) { | ||
| throw new Error(`Duplicate value "${value}" found — cannot invert`); | ||
| } | ||
| invertedObj[String(value)] = key; |
Contributor
There was a problem hiding this comment.
All values (except Symbol) when used as keys, are converted implicitly to string. So a cast to string is optional.
cjyuan
added
Reviewed
… properties in prototype chain
RaihanSharif
added
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Done all exercises. For the invert exercises, made decision to prevent inverting where multiple keys have the same value. e.g. {a: "f", b: "f"} as this would produce {f: "b"}, thereby losing some information.