Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 1 | Exercises#1219

Open
RaihanSharif wants to merge 12 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-1
Open

London | 26-ITP-May | Raihan Sharif | Sprint 1 | Exercises#1219
RaihanSharif wants to merge 12 commits into
CodeYourFuture:mainfrom
RaihanSharif:sprint-1

Conversation

@RaihanSharif
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed exercises as per specs.

@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels May 7, 2026
Comment thread Sprint-1/implement/dedupe.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 10, 2026
@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 11, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

Comment thread Sprint-1/implement/dedupe.test.js Outdated
Comment on lines +35 to +37
expect(dedupe([1, 3, 3, "as", "as", "df"])).toEqual([1, 3, "as", "df"]);
const inputArr = [1, 3, 3, "as", "as", "df"];
expect(dedupe(inputArr)).toEqual([1, 3, "as", "df"]);
expect(dedupe(inputArr)).not.toBe(inputArr);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposedly the check is expected in the previous test. Well, at least you know how to carry out the test.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants