Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 2 | Book Library#491

Closed
RaihanSharif wants to merge 15 commits into
CodeYourFuture:mainfrom
RaihanSharif:library
Closed

London | 26-ITP-May | Raihan Sharif | Sprint 2 | Book Library#491
RaihanSharif wants to merge 15 commits into
CodeYourFuture:mainfrom
RaihanSharif:library

Conversation

@RaihanSharif
Copy link
Copy Markdown

@RaihanSharif RaihanSharif commented May 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed following bugs:

  1. Website loads but doesn't show any books
  2. Error in console when you try to add a book
  3. It uses the title name as the author name
  4. Delete button is broken
  5. When I add a book that I say I've read - it saves the wrong answer

@github-actions

This comment has been minimized.

@RaihanSharif RaihanSharif changed the title London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock London | 26-ITP-May | Raihan Sharif | Sprint 2 | Book Library May 8, 2026
@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels May 8, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 10, 2026
@RaihanSharif RaihanSharif deleted the library branch May 10, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. Submit:PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants