[Refactor] Profile Page #3

Activity

1. Anurag5086

   added

   refactor

   on Sep 24, 2021
2. Anurag5086

   assigned

   bhavesh1235

   on Sep 24, 2021
3. Anurag5086

   added

   hacktoberfest

   on Sep 30, 2021
4. VB-17 commented on Oct 3, 2021

   

   VB-17

   on Oct 3, 2021

   Last edited by VB-17

   Contributor

   More actions

   Hey ! I have been working on refactoring the profile page and i have refactored it partially, also i have formatted all the files in the project using a prettier script npx prettier --write \"./**/*.{js,jsx,json,css}\" . I just wanted to know that even though you have an error state it is not being used anywhere in the component . So what should i do with that ? Also i have reduced the tab width in .prettierrc to 2 because long files with tab width as 4 were very difficult to navigate.

   const [error, setError] = useState(true)
5. Anurag5086 commented on Oct 4, 2021

   

   Anurag5086

   on Oct 4, 2021

   Last edited by Anurag5086

   MemberAuthor

   More actions

   @VB-17 Thank you for your interest in this issue.
   I would suggest you to open a separate issue for the same.
   Add the prettier script into the package.json file as a script and raise a PR for the same.

   For now we can comment out the error state as we may need it in future.

   Here are few practices which we need to ensure while refactoring a file-

   1. Removing the inline CSS and adding them into a separate CSS file.
   2. Breaking the page into smaller components and reusing them when needed.
   3. Adding all the API calls into the actions directory.
   4. Making sure the code is modular enough.

   Looking forward to your contribution :)
   In case you have any blockers, feel free to reach out.
6. Anurag5086

   assigned

   VB-17

   and unassigned

   VB-17

   on Oct 4, 2021