Fix - Christmas bug#8
Open
marcocianetti wants to merge 2 commits into
Open
Conversation
christianechevarria
added a commit
to christianechevarria/neat.js
that referenced
this pull request
Jun 8, 2020
PrashanthSubramanianMS
approved these changes
Apr 12, 2022
PrashanthSubramanianMS
left a comment
PrashanthSubramanianMS
left a comment
There was a problem hiding this comment.
Tested locally and works
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I just tried to fix this bug and I think that the problem was into the "random number" that was used in each Pipe object, with different values.
I removed it and all seems to be good now.
I introduced a random factor to panSpeed, so it's applied to each Pipe.
Oh, and I added a real check for the Christmas day 🎄
Hope it helps,
thanks for your work.
Marco.