Repository navigation
Conversation
|
|
||
| ## imports | ||
|
|
||
| Source: the app, one row per uploaded spreadsheet. |
There was a problem hiding this comment.
add note that these are irrevocable/unmodifiable, logs
Entities and generated migration for users, imports, daily/hourly/scheduled observations, daily records and audit log, plus docs/database-schema.md mapping each column to its source cell in the example sheets.
Add s3Key to imports in the doc.
Client confirmed more stations are coming, so stationId joins the keys of the three daily tables now rather than in a later migration. Every row comes from an upload, so importId is not null on observations and records.
Keying records by station now avoids changing their primary key later if records become per-station. The hourly notes now say what column H's fractions and column I's weather codes mean.
naman0r
marked this pull request as ready for review
October 6, 2026 01:14
Rayna-Yu
approved these changes
Oct 6, 2026
Rayna-Yu
left a comment
Rayna-Yu
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
Non-blocking: One thing to note though, is I think pg parses a Postgres date at the server's local midnight. So that would be UTC in Lambda and Eastern for our laptops. This shouldn't be an issue because we are planning on running everything in Lambdas anyways, but something that we may need to be careful about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database schema
Closes #3
📝 Description
Work in progress. This PR will carry the reviewed database core tables and schema for BHO, based on the product spec and the example data (daily observation sheets, F-6, hourly precipitation, daily records, narratives).
The schema is being drafted in a shared doc for team review first; this PR will be updated once the tables are agreed on.
✔️ Verification
no verification
🏕️ (Optional) Future Work / Notes
Open questions for the team (location of the full 141-year daily archive, normals data, canonical units, trace/missing value handling) will be listed here once the doc is shared.
hourly_observations.mountainVis(column K, "Mnts VSBL", e.g.1@1.5) stays text for now. Per the client, it is mountain number @ visibility on a 1-3 scale. Once the weather group sends which number is which mountain, split it intomountainIdandmountainVisibility, with amountainslookup table rather than an enum. Still unknown: whether one cell can list more than one mountain.