Skip to content

fix(uploader): error out when profile archive exceeds upload size limit - #557

Merged
lvaroqui merged 1 commit into
mainfrom
cod-2322-upload-failure-when-compressed-archive-is-still-larger-than
Sep 30, 2026
Merged

lvaroqui merged 1 commit into
mainfrom
cod-2322-upload-failure-when-compressed-archive-is-still-larger-than

Conversation

@lvaroqui

Copy link
Copy Markdown
Contributor

No description provided.

@lvaroqui
lvaroqui force-pushed the cod-2322-upload-failure-when-compressed-archive-is-still-larger-than branch from 3222a84 to 58b7ef2 Compare September 30, 2026 13:56
@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Renames upload size limit constant and updates references.

The PR appears safe to merge.

Summary

The PR rejects profile archives larger than 5 GiB before upload. Since the previous review, it has only clarified the size-limit documentation.

Reviews (2) · Last reviewed commit: "fix(uploader): error out when profile ar..."

Comment thread src/upload/uploader.rs
Comment thread src/upload/uploader.rs

@GuillaumeLagrange GuillaumeLagrange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codspeed

codspeed Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 33 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing cod-2322-upload-failure-when-compressed-archive-is-still-larger-than (8459917) with main (080ed5f)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@lvaroqui
lvaroqui force-pushed the cod-2322-upload-failure-when-compressed-archive-is-still-larger-than branch from 58b7ef2 to 8459917 Compare September 30, 2026 14:16
@lvaroqui
lvaroqui merged commit 26e4fa9 into main Sep 30, 2026
103 of 105 checks passed
@lvaroqui
lvaroqui deleted the cod-2322-upload-failure-when-compressed-archive-is-still-larger-than branch September 30, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants