Skip to content

feat: enable rss tracking + memory flamegraphs by default - #553

Merged
not-matthias merged 2 commits into
mainfrom
cod-3678-enable-rss-tracking-memory-flamegraphs-by-default
Sep 29, 2026
Merged

not-matthias merged 2 commits into
mainfrom
cod-3678-enable-rss-tracking-memory-flamegraphs-by-default

Conversation

@not-matthias

@not-matthias not-matthias commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@not-matthias
not-matthias marked this pull request as ready for review September 28, 2026 14:45
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes default behavior for memory profiling features.

The PR appears safe to merge based on the changes since the previous review and the disposition of the earlier threads.

Summary

The PR enables resident-memory tracking and allocation stack capture by default, adds opt-out flags, and retains deprecated memory flags with falsey-value support.

  • Both run and exec resolve the memory settings before building the orchestrator configuration.
  • The change since the previous review restores the samply-codspeed pin to the base branch’s revision.

Reviews (2) · Last reviewed commit: "fix: honor falsey values of the deprecat..."

Comment thread src/cli/shared.rs
Comment thread src/cli/experimental.rs
@codspeed

codspeed Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 33 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing cod-3678-enable-rss-tracking-memory-flamegraphs-by-default (a15fad1) with main (7c135cc)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (98ef901) during the generation of this report, so 7c135cc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Physical memory tracking and allocation stack capture in memory mode
are no longer experimental and are enabled by default. Opt out with the
new --disable-memory-track-physical / --disable-memory-capture-stack
flags (env: CODSPEED_DISABLE_MEMORY_TRACK_PHYSICAL,
CODSPEED_DISABLE_MEMORY_CAPTURE_STACK).

The --experimental-memory-track-physical and
--experimental-memory-capture-stack flags still work but are hidden and
warn that they are deprecated; disable flags take precedence when both
are set.
The deprecated --experimental-memory-track-physical and
--experimental-memory-capture-stack flags were parsed as plain bools and
then ignored, so the old opt-out via a falsey env value
(CODSPEED_MEMTRACK_TRACK_PHYSICAL=0) silently enabled tracking instead.

Both flags are now Option<bool> so unset, enabled, and explicitly
disabled are distinguishable. resolve_memory_track_physical() and
resolve_memory_capture_stack() combine them with the new
--disable-memory-track-physical / --disable-memory-capture-stack flags:
any explicit opt-out wins.
@not-matthias
not-matthias force-pushed the cod-3678-enable-rss-tracking-memory-flamegraphs-by-default branch from e16c32c to a15fad1 Compare September 29, 2026 09:07
@not-matthias
not-matthias merged commit a15fad1 into main Sep 29, 2026
57 checks passed
@not-matthias
not-matthias deleted the cod-3678-enable-rss-tracking-memory-flamegraphs-by-default branch September 29, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants