chore: minimal complexity reduction in unsafe replacement#1678
Merged
Conversation
derklaro
added
v: 4.X
0utplay
previously approved these changes
Jul 2, 2025
0utplay
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some complexity in CAS operations can be reduced. Additionally the ByteBuffer cleaning MethodHandle can be reduced to a single one instead of having to call multiple manually.
Modification
Use
compareAndSetfrom VarHandle instead ofcompareAndExchangeas it doesn't require the manual equality check. The ByteBuffer cleaning MethodHandle is now compacted into a single one which does all the current manual steps.Result
A bit less complexity in unsafe replacement.