fix: only handle npc interact when performed with main hand#1673
Merged
Conversation
Test Results 56 files ±0 56 suites ±0 3m 3s ⏱️ +36s Results for commit b817365. ± Comparison against base commit 5c85c01. This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
0utplay
previously approved these changes
Jun 30, 2025
0utplay
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The client sends the interact packet twice (in most cases): once for the main hand and once for the off hand. This causes all right click actions of selector entities to be executed twice.
Modification
Only actually handle the right click action to a selector entity if the interact happened with the main hand. In all other cases we just ignore the interact and, if needed, just cancel the interact event (required to cancel certain actions on mobs such as shearing a sheep).
Result
Selector entity right click actions are only performed once, not twice in many cases.
Other context
https://canary.discord.com/channels/325362837184577536/818777626663321671/1388872733903028265