feat: conditionally disable netty unsafe to leverage the ffm api#1664
Merged
Conversation
0utplay
previously approved these changes
Jun 22, 2025
0utplay
previously approved these changes
Jun 28, 2025
0utplay
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In netty 4.2.3 a new type of ByteBuffer cleaner (or allocator) will be introduced that uses
mallocandfreedirectly using the ffm api on java 24+. In order to enable this cleaner, unsafe has to be unavailable/disabled. Since this can be a performance issue (as the ByteBuffer lifecycle might be controlled by the garbage collector if unsafe is unavailable) we only disable unsafe when the new cleaner implementation is available.Modification
Add a transformer that checks if all conditions are met to disable unsafe in order to enable the ffm-based cleaner implementation. If that is the case, the
PlatformDependent0#explicitNoUnsafeCause0()method will be overridden to always return an UOE to indicate that unsafe is explicitly disabled.Result
On netty 4.2.3+ unsafe will be disabled in favor of the ffm-linker based cleaner implementation, but only is all necessary preconditions to enable the cleaner are met.