fix: singleton annotation locations#1642
Merged
Merged
Conversation
derklaro
added
p: high
0utplay
approved these changes
May 26, 2025
derklaro
added a commit
that referenced
this pull request
May 26, 2025
### Motivation Some singleton annotations were located at the wrong places and should be moved to their respective factory methods. ### Modification The singleton annotation for the node configuration was located both on the implementation and the interface. This is not acceptable as scope annotations are not allowed on interfaces/abstract classes and the implementation is not relevant to the binding builder, therefore the annotation was ignored there anyway. Same applies to the wrapper configuration. ### Result The singleton scope annotations are now located at the factory methods rather than at locations where they don't have any effect.
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
### Motivation Some singleton annotations were located at the wrong places and should be moved to their respective factory methods. ### Modification The singleton annotation for the node configuration was located both on the implementation and the interface. This is not acceptable as scope annotations are not allowed on interfaces/abstract classes and the implementation is not relevant to the binding builder, therefore the annotation was ignored there anyway. Same applies to the wrapper configuration. ### Result The singleton scope annotations are now located at the factory methods rather than at locations where they don't have any effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some singleton annotations were located at the wrong places and should be moved to their respective factory methods.
Modification
The singleton annotation for the node configuration was located both on the implementation and the interface. This is not acceptable as scope annotations are not allowed on interfaces/abstract classes and the implementation is not relevant to the binding builder, therefore the annotation was ignored there anyway. Same applies to the wrapper configuration.
Result
The singleton scope annotations are now located at the factory methods rather than at locations where they don't have any effect.