fix: language question result conversion in default setup#1640
Merged
Conversation
0utplay
approved these changes
May 26, 2025
Test Results 50 files ±0 50 suites ±0 1m 28s ⏱️ +7s Results for commit 7bc088c. ± Comparison against base commit d36b7b7. This pull request removes 31 and adds 31 tests. Note that renamed tests count towards both. |
0utplay
pushed a commit
that referenced
this pull request
May 26, 2025
### Motivation The code for selecting the language in the default task setup was changed to use locales instead of strings, however the result handling was not changed accordingly. This results in a class cast exception when the results are being processed. ### Modification Change the default setup result handler to use locales instead of strings. ### Result No more class cast exceptions when completing the default config setup. (cherry picked from commit 85defd7)
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
…rvice#1640) ### Motivation The code for selecting the language in the default task setup was changed to use locales instead of strings, however the result handling was not changed accordingly. This results in a class cast exception when the results are being processed. ### Modification Change the default setup result handler to use locales instead of strings. ### Result No more class cast exceptions when completing the default config setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The code for selecting the language in the default task setup was changed to use locales instead of strings, however the result handling was not changed accordingly. This results in a class cast exception when the results are being processed.
Modification
Change the default setup result handler to use locales instead of strings.
Result
No more class cast exceptions when completing the default config setup.