improve: wrapped application invocation exception handling#1639
Merged
Conversation
Test Results 51 files +1 51 suites +1 1m 17s ⏱️ -13s Results for commit 9603354. ± Comparison against base commit adbe832. This pull request removes 36 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When starting e.g. a BungeeCord proxy and the proxy fails to start due to missing native libraries. Currently CloudNet would not catch that the service is actually stopped and would display it as "RUNNING".
Modification
Handle exceptions thrown after invoking the main method and halt the wrapper jvm.
Result
No services are displayed as running after they crashed in the start period.