Skip to content

improve: wrapped application invocation exception handling#1639

Merged
0utplay merged 9 commits into
nightlyfrom
wrapped-application-exception-handling
Jun 16, 2025
Merged

improve: wrapped application invocation exception handling#1639
0utplay merged 9 commits into
nightlyfrom
wrapped-application-exception-handling

Conversation

@0utplay

@0utplay 0utplay commented May 26, 2025

Copy link
Copy Markdown
Member

Motivation

When starting e.g. a BungeeCord proxy and the proxy fails to start due to missing native libraries. Currently CloudNet would not catch that the service is actually stopped and would display it as "RUNNING".

Modification

Handle exceptions thrown after invoking the main method and halt the wrapper jvm.

Result

No services are displayed as running after they crashed in the start period.

@0utplay 0utplay self-assigned this May 26, 2025
@github-actions

github-actions Bot commented May 26, 2025

Copy link
Copy Markdown

Test Results

 51 files  +1   51 suites  +1   1m 17s ⏱️ -13s
452 tests +6  452 ✅ +6  0 💤 ±0  0 ❌ ±0 
783 runs  +6  783 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 9603354. ± Comparison against base commit adbe832.

This pull request removes 36 and adds 42 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-06-07
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 14:00:42.665718234
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 14:00:42.665837978Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 14:00:42.665861883Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 14:00:42.665887370+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 14:00:42.666092274-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-07T14:00:42.666247204
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-07T14:00:42.666382707Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-07T14:00:42.662170428Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-06-15
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 21:09:37.290779884
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 21:09:37.290900329Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 21:09:37.290922701Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 21:09:37.290942889+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 21:09:37.290957015-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-15T21:09:37.291505882
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-15T21:09:37.291656985Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-15T21:09:37.287393807Z
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay requested a review from derklaro May 26, 2025 13:34
@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: wrapper An issue/pull request releated to the wrapper module code labels May 26, 2025
@0utplay 0utplay added this to the 4.0.0-RC13 milestone May 26, 2025
@derklaro derklaro changed the title fix: improve handling of wrapped application starts improve: wrapped application invocation exception handling Jun 13, 2025
@0utplay 0utplay marked this pull request as ready for review June 15, 2025 21:04
@0utplay 0utplay merged commit efe9f3a into nightly Jun 16, 2025
5 checks passed
@0utplay 0utplay deleted the wrapped-application-exception-handling branch June 16, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: wrapper An issue/pull request releated to the wrapper module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants