ci: fine-tune the build action a bit#1630
Merged
Merged
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
May 22, 2025
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
### Motivation The build action needs some fine tuning and cleanup as it does not work as expected in some scenarios. ### Modification 1. Remove all references to the old github merge queue experiment, this is no longer needed and is annoying when reading the action. 2. Replace deprecated `junit_files` input of the unit test publish action and always publish unit tests results. Comments on pull requests are now disabled unless the action is triggered by a pull request (to prevent duplicate comments for pushes and the pull request run). 3. The updater metadata is now only published if the action is triggered by a push or workflow dispatch. 4. Artifacts generated by the action are now always uploaded (there is no reason to not do it). ### Result The build action is easier to read and behaves more as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The build action needs some fine tuning and cleanup as it does not work as expected in some scenarios.
Modification
junit_filesinput of the unit test publish action and always publish unit tests results. Comments on pull requests are now disabled unless the action is triggered by a pull request (to prevent duplicate comments for pushes and the pull request run).Result
The build action is easier to read and behaves more as expected.