Skip to content

Refactor SNV germline ClinVar submissions#5994

Open
northwestwitch wants to merge 234 commits into
mainfrom
deprecate_current_germline_clinvar_submissions
Open

Refactor SNV germline ClinVar submissions#5994
northwestwitch wants to merge 234 commits into
mainfrom
deprecate_current_germline_clinvar_submissions

Conversation

@northwestwitch

@northwestwitch northwestwitch commented Jan 28, 2026

Copy link
Copy Markdown
Member

This PR adds a functionality or fixes a bug.

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. First book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout@<name_of_currently_deployed_branch>
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by CR

@northwestwitch northwestwitch force-pushed the deprecate_current_germline_clinvar_submissions branch from a6ee603 to 96e9370 Compare January 28, 2026 14:21
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.67742% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.81%. Comparing base (5e26627) to head (b8fc14b).

Files with missing lines Patch % Lines
scout/adapter/mongo/clinvar.py 79.31% 6 Missing ⚠️
scout/server/blueprints/clinvar/controllers.py 90.19% 5 Missing ⚠️
scout/server/blueprints/clinvar/views.py 88.63% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5994      +/-   ##
==========================================
- Coverage   84.08%   83.81%   -0.27%     
==========================================
  Files         347      347              
  Lines       21835    21717     -118     
==========================================
- Hits        18359    18203     -156     
- Misses       3476     3514      +38     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@northwestwitch

Copy link
Copy Markdown
Member Author

Summer and holidays start to feel the right period to merge this one. We can perhaps merge it before July so I can work on a couple of other PRs to complement it (include SVs and another one I don't remember now) so we'll be done when everyone is back at the office

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants