refactor(cork): rename picket-fence radiation scheme to CORK (correlated-k)#213
Merged
Conversation
Automated band-placement optimizer on top of the linepyline correlated-k generator: greedy residual-driven loop seeded by a spectral correlation- breakdown split metric, encoding the band-refinement campaign learnings (band width over g-points, wide window, continuum decoupling for moist). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ptance 10-task TDD plan: refactor assemble_lw_table, OptimizerConfig, cached kappa-cube/LBL-truth (linepyline env), correlation-breakdown split metric, choose_action brain, greedy loop with stall->best-so-far, CLI driver, and a manual end-to-end Earth-LW smoke gate. Spec acceptance narrowed to an OLR hard gate with heating-rate reported (gating deferred to v2). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ted-k)
The scheme is now a full correlated-k code, not the original Parmentier &
Guillot two-band gray ("picket fence") approximation, so the name no longer
fits. Rename to CORK (CORrelated-K) throughout:
- Package climt._components.picket_fence -> climt._components.cork
- Data climt._data.picket_fence -> climt._data.cork
- Classes PicketFence{Longwave,Shortwave} -> Cork{Longwave,Shortwave}Radiation
- Tests, scripts, table-builder, benchmarks, and docs (incl. dated
plans/specs) renamed; pf/PF abbreviations swept.
Preserved: the analytic gray path is still optics="parmentier"
(climt._components.cork.optics.parmentier) and the parmentier2014 citation /
"non-grey analytical model" wording are unchanged -- "picket fence" remains
the literature term for the Parmentier & Guillot approximation itself.
Data .nc/.npz tables relocated via git mv (bytes unchanged). Graph
regenerated (graphify update + augment_graph.py).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the radiation component formerly called picket fence to CORK (CORrelated-K) throughout the codebase.
climt._components.picket_fence→climt._components.corkclimt._data.picket_fence→climt._data.corkPicketFenceLongwave/PicketFenceShortwave→CorkLongwaveRadiation/CorkShortwaveRadiationscripts/cork_table_builder/,tests/cork_table_builder/), benchmarks, and docs (including dated plans/specs) renamed;pf/PFabbreviations swept.Why
The scheme is now a full correlated-k code, not the original Parmentier & Guillot two-band gray ("picket fence") approximation, so the old name no longer describes what it does. CORK is short, pronounceable, and encodes "correlated-k".
What is deliberately not renamed
The analytic gray path is still
optics="parmentier"(climt._components.cork.optics.parmentier), and theparmentier2014citation / "non-grey analytical model" wording are unchanged. "Picket fence" remains the correct literature term for the Parmentier & Guillot approximation itself — only the project's own scheme name changed.Reviewer notes
cork/Python diff is name-only (14 insertions / 14 deletions across 7 files; every removed line carried a picket/pf token). No numerical logic changed.git mv— bytes unchanged.develop, so it incorporates the wheel-slim work (PR chore: slim wheel/sdist, drop stale Chaverot Earth LW tables #209): the 6 stale Earth LW tables stay deleted (not resurrected undercork/), andsetup.py/MANIFEST.intrimming is preserved.graphify update+augment_graph.py).test_hd209458b_reproduction2%-regression test is a pre-existing tolerance issue independent of this rename (identical kernels + byte-identical k-tables ⇒ identical physics) and is left untouched.🤖 Generated with Claude Code