Skip to content

Better show for RotatedLatitudeLongitudeGrid and LambertConformalConicGrid#5709

Merged
navidcy merged 9 commits into
mainfrom
ncc/better-show-RotatedLatitudeLongitudeGrid
Jun 21, 2026
Merged

Better show for RotatedLatitudeLongitudeGrid and LambertConformalConicGrid#5709
navidcy merged 9 commits into
mainfrom
ncc/better-show-RotatedLatitudeLongitudeGrid

Conversation

@navidcy

@navidcy navidcy commented Jun 20, 2026

Copy link
Copy Markdown
Member

Before this PR:

julia> grid = RotatedLatitudeLongitudeGrid(; size = (24, 6, 5), latitude = (-90, 90), longitude=(0, 360), z=(-100, 0), north_pole = (0, 0))
24×6×5 OrthogonalSphericalShellGrid{Float64, Periodic, Bounded, Bounded} on CPU with 3×3×3 halo
├── centered at: North Pole, (λ, φ) = (116.565, 90.0)
├── longitude: Periodic  extent 360.0 degrees variably spaced with min(Δλ)=9.18485e-16, max(Δλ)=15.0
├── latitude:  Bounded  extent 180.0 degrees  variably spaced with min(Δφ)=30.0, max(Δφ)=30.0
└── z:         Bounded  z  [-100.0, 0.0]     regularly spaced with Δz=20.0

After this PR

julia> grid = RotatedLatitudeLongitudeGrid(; size = (24, 6, 5), latitude = (-90, 90), longitude=(0, 360), z=(-100, 0), north_pole = (0, 0))
24×6×5 RotatedLatitudeLongitudeGrid{Float64, Periodic, Bounded, Bounded} on CPU with 3×3×3 halo
├── singularities at (λ, φ) = (0, 0) and (180, 0)
├── longitude: Periodic  extent 360.0 degrees variably spaced with min(Δλ)=9.18485e-16, max(Δλ)=15.0
├── latitude:  Bounded  extent 180.0 degrees  variably spaced with min(Δφ)=30.0, max(Δφ)=30.0
└── z:         Bounded  z  [-100.0, 0.0]     regularly spaced with Δz=20.0

@glwagner

Copy link
Copy Markdown
Member

Nice!

I wonder if we should say RotatedLatitudeLongitudeGrid rather than OrthogonalSphericalShellGrid but I see advantages of the latter

Comment thread src/Grids/orthogonal_spherical_shell_grid.jl Outdated
@navidcy

navidcy commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

Yes. I think if the show says "RotatedLatitudeLongitudeGrid" is more informative. I’ll add a specific summary method.

@navidcy navidcy changed the title Better show for RotatedLatitudeLongitudeGrid Better show for RotatedLatitudeLongitudeGrid and LambertConformalConicGrid Jun 21, 2026
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.93%. Comparing base (d012d56) to head (b1d5621).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Grids/orthogonal_spherical_shell_grid.jl 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5709      +/-   ##
==========================================
- Coverage   73.94%   73.93%   -0.01%     
==========================================
  Files         418      418              
  Lines       25257    25260       +3     
==========================================
  Hits        18676    18676              
- Misses       6581     6584       +3     
Flag Coverage Δ
buildkite 68.57% <76.92%> (-0.01%) ⬇️
julia 68.57% <76.92%> (-0.01%) ⬇️
reactant_1 6.01% <0.00%> (-0.01%) ⬇️
reactant_2 10.78% <0.00%> (-0.01%) ⬇️
reactant_3 9.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@navidcy navidcy merged commit 2e23fb4 into main Jun 21, 2026
89 checks passed
@navidcy navidcy deleted the ncc/better-show-RotatedLatitudeLongitudeGrid branch June 21, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants