Fill halos after checkpoint pickup, enables changes in barotropic substep values#5691
Open
taimoorsohail wants to merge 32 commits into
Open
Fill halos after checkpoint pickup, enables changes in barotropic substep values#5691taimoorsohail wants to merge 32 commits into
substep values#5691taimoorsohail wants to merge 32 commits into
Conversation
…mat imports - Consolidate same_interior_grid methods into single generic implementation * Remove compare_grid_field helper * Single implementation for all grid types, with special handling for ImmersedBoundaryGrid * Use _halo_excluded_fields() helper constant for clarity - Format checkpoint-related imports across model files * Hydrostatic, Nonhydrostatic, and ShallowWater models now use consistent multi-line format * Improves readability and makes import list easier to maintain - Add finalize_compatible_grid_restore! helper in checkpointer.jl * Reduces code duplication in model-specific checkpoint restoration * Centralizes common halo filling and field masking logic
taimoorsohail
changed the title
substep values
navidcy
reviewed
Jun 18, 2026
…igans.jl into ts/fill-halos-after-pickup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5608
This PR enables pickup with a different number of model halos and/or free surface halos.
The pickup path first checks if the interior grid is the same, then if the halos are the same OR the free surface halos are the same. If the interior grid and halos are the same, the model carries the
RestoreonCurrentGridmode, and if the interior is the same but halos are not, then the model carries theRestoreonCompatibleGridmode. This then restores the interior, then builds the halos usingfill_halos.