Use ConjugateGradientPoissonSolver as default for immersed boundary grids#5687
Open
xkykai wants to merge 1 commit into
Open
Use ConjugateGradientPoissonSolver as default for immersed boundary grids#5687xkykai wants to merge 1 commit into
xkykai wants to merge 1 commit into
Conversation
…teGradientPoissonSolver and remove warning message
Member
|
5x is a massive hit, not a slight! not to say this isn't the right choice but it should be advertised correctly |
Member
|
It'll be easier to change the default after we implement the Fast Runge-Kutta. Is that still being worked on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@glwagner @simone-silvestri @navidcy @tomchor I think we are ready! But I'll only merge this after #5650 is done.
I suppose this will come at a slight hit to compute cost from the original default (~5x for typical problems) but at least the solutions are correct.
Also happy to abandon this if folks think it's better to use the faster (but slightly wrong) version.